Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gimmepeers torrent provider #6635

Merged
merged 36 commits into from
May 3, 2019
Merged

Add gimmepeers torrent provider #6635

merged 36 commits into from
May 3, 2019

Conversation

mystycs
Copy link
Contributor

@mystycs mystycs commented May 2, 2019 •
edited
Loading

Popular torrent provider which used to be bitsoup.me on the old sickrage.

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@ghost
Copy link

ghost commented May 2, 2019

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

@ghost
Copy link

ghost commented May 2, 2019

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

@ghost
Copy link

ghost commented May 2, 2019

DeepCode analyzed this pull request.
There are 2 new info reports.

Click to see more details.

@ghost
Copy link

ghost commented May 2, 2019

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

medariox
medariox requested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Generally, it looks pretty good 👍
A few changes are required before it can be merged.

medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented May 2, 2019

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

@mystycs
Copy link
Contributor Author

mystycs commented May 2, 2019 •
edited
Loading

all changes have been implemented as requested @p0psicles @medariox

thanks!

@mystycs
Copy link
Contributor Author

mystycs commented May 2, 2019

all fixed up! @p0psicles @medariox

medariox
medariox requested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Almost there! 👍

The provider doesn't have a published date?
See https://github.com/pymedusa/Medusa/blob/master/medusa/providers/torrent/html/alpharatio.py#L155-L156

medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
medusa/providers/torrent/html/gimmepeers.py Outdated Show resolved Hide resolved
@mystycs
Copy link
Contributor Author

mystycs commented May 2, 2019 •
edited
Loading

@medariox all fixed up. I also fixed the size portion since it was pulling from the wrong cell.

@mystycs
Copy link
Contributor Author

mystycs commented May 2, 2019 •
edited
Loading

@medariox added the publish date as well, I missed that earlier.

medariox
medariox previously approved these changes May 3, 2019
View reviewed changes
medariox
medariox previously approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mystycs

@medariox medariox added this to the 0.3.2 milestone May 3, 2019
@medariox medariox merged commit ecbfe45 into pymedusa:develop May 3, 2019
Thilas pushed a commit to Thilas/Medusa that referenced this pull request Jun 5, 2019
@mystycs @Thilas
Add gimmepeers torrent provider (pymedusa#6635)
ef658fe 
* Create gimmepeers.py

* Update __init__.py

* Update __init__.py

* Add files via upload

* Add files via upload

* Update gimmepeers.py

* run isort

* Update gimmepeers.py

* Update gimmepeers.py

* make pep8 compliant for flake8 check

* Update gimmepeers.py

* pep8 fixes

* Update gimmepeers.py

* pep8 fixes

* pep8 fix import order

* revert isort

* revert isort

* Add files via upload

* pr fixes

* pr fix minseed

* fix logger

* remove logger since unused

* Update gimmepeers.py

* remove whitespace

* replace format with urljoin

* pr fixes + add pubdate

* pep8 whitespace fix

* pep8 whitespace fix

* fix size

* whitespace fix

* remove trailing whitespace

* Small changes

* Optimize icon

* Update gimmepeers.py

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

@medariox medariox medariox left review comments

Assignees
No one assigned
Labels
Concluded
Projects
None yet
Milestone
0.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mystycs @p0psicles @medariox