Feature/vueify display show rebased #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert code thats used for show recent.
…ue later if we want to) Added vue-tables-2 component to create the tables. (just implemented the minimal for now). It should allow us to implement filtering of the columns. Added EpisodeRow component. This should get removed with vue-tables-2 child rows. But I need to figure out how this works.
Any change should now be done in the .Vue file anyway Used the Boolean as per the review comment.
Removed displayShow.mako files
Synced sorting over child tables.
Used the group table feature. No styling applied.
* Added column selector * For the airDate used a default date format. Need to use the dateformat from config.
As i've started doing PR's at https://xaksis.github.io/, but havent gotten much feedback yet. Yet I want to continue on my development, and therefor have choosen the "temporary" folder monkeypatched for the time being.
* Added color by row status (skipped, failed, downloaded, etc) * Overall styling improvements.
* Added subtitle-search.vue component * Add vue-js-modal module, to create quick vue modals. * Display subtitle-search.vue component in the table row, when choosen for manual search.
|
@medariox i'm kinda getting into the final stage of this pr. How do we proceed with this? |
|
A few things I've noticed so far:
|
* Changed field to label, to make it more consistant.
* Added file.name to episode to_json. * Added class for centering spans.
* Added qTip labels to the headers. * Fixed double season numbers.
* It's now activated using the vue-good-table prop column-filter-options. * Fixed warning at searchSubtitles. Used to many parameters. * Renamed absolute episode and scene absolute column labels. Updated the styles for the vgt-dropdown-menu class.
medariox
approved these changes
Oct 16, 2019
medariox
added
Confirmed
Concluded
and removed
Do not merge
In progress
Confirmed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checklist
change status tobuttonchange quality tobuttonSeason contains 6 episodes with total filesize: 9.06 GBshow all seasonsoption- [ ] implementonly applies to snatchSelectionfuzzy datesoptionI've created a set of smaller PR's to offload this one. Merged in this order:
This will be the (reased) base PR/branch. For the coming weeks i'll start creating smaller PR's, and try to reduce this PR in size where possible.
continued from #6315
Tnx. @sharkykh