Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QualityChooser #6918

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Fix QualityChooser #6918

merged 3 commits into from
Jul 5, 2019

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Jul 5, 2019

From Slack

Add New Show quality chooser not loading the default quality (it's loading then setting it to null because of the await waitFor(...) 😕)
image

@sharkykh sharkykh added this to the 0.3.5 milestone Jul 5, 2019
@sharkykh sharkykh removed the Concluded label Jul 5, 2019
@sharkykh
Copy link
Contributor Author

sharkykh commented Jul 5, 2019 •
edited
Loading

Vue-Test-Utils is moving towards async tests by default

The component still works great in the browser,
and I think it wasn't rendering the element synchronously on the tests.
Possibly due to the breaking change linked above.

@p0psicles p0psicles merged commit c77a19a into develop Jul 5, 2019
@p0psicles p0psicles deleted the bugfix/add-new-show branch July 5, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Bug Concluded Frontend
Projects
None yet
Milestone
0.3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkykh @p0psicles