-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qBittorrent client maintenance #7474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Warn when username/password is invalid. - Warn when your IP is banned by the client (after too many failed authentication attempts).
sharkykh
force-pushed
the
bugfix/qbittorrent
branch
from
December 12, 2019 01:26
9dde8d9
to
97fa5b8
Compare
sharkykh
added
Concluded
and removed
Changelog
Requires a changelog entry
In progress
labels
Dec 12, 2019
sharkykh
force-pushed
the
bugfix/qbittorrent
branch
from
December 12, 2019 01:30
97fa5b8
to
d770407
Compare
sharkykh
changed the title
WIP: qBittorrent client maintenance
qBittorrent client maintenance
Dec 12, 2019
sharkykh
force-pushed
the
bugfix/qbittorrent
branch
from
December 12, 2019 01:50
d770407
to
6cc9a8b
Compare
medariox
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly for me (Windows 10). Thanks 👍
This was referenced Dec 12, 2019
fernandog
pushed a commit
to fernandog/Medusa
that referenced
this pull request
Jan 11, 2020
* Warn when you need to create the label first * Handle API authentication errors better - Warn when username/password is invalid. - Warn when your IP is banned by the client (after too many failed authentication attempts). * Fix incorrect API version format * Update `_get_auth` docstring * Rename client * Use `urljoin` * Rewrite API authentication and version-getting * Update changelog * Restore authentication test functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Fixes:
I'll try to figure out a better way to do this in this PR. Hopefully before the hotfix is released.
urljoin
Tested with: