Add own absolute numbering for tvmaze and tmdb. #8777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p0psicles
commented
Nov 28, 2020
•
p0psicles
commented
- Remove anime restriction for tvmaze and tmdb.
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
* Remove anime restriction for tvmaze and tmdb.
p0psicles
commented
Nov 28, 2020
| @@ -295,6 +295,8 @@ def _get_episodes(self, tmdb_id, specials=False, aired_season=None): # pylint: | |||
| if not isinstance(episodes, list): | |||
| episodes = [episodes] | |||
|
|
|||
| absolute_number_counter = 1 | |||
There was a problem hiding this comment.
@medariox what do you think about this to add absolute numbering, when the indexer does not provide it?
…dexer-anime # Conflicts: # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js
Changed to 1_0 as this is all cats in anime.
(where slowly translating this to -> absolute numbering in stead of anime)
coptere
pushed a commit
to coptere/Medusa
that referenced
this pull request
Jan 27, 2021
* Add own absolute numbering for tvmaze and tmdb. * Remove anime restriction for tvmaze and tmdb. * Adding comment, as i might need to look at that later. * Build themes after upmerge * Category 4_0 is live action? Changed to 1_0 as this is all cats in anime. * Correct option description for anime. (where slowly translating this to -> absolute numbering in stead of anime) * Update changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.