-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start to vueify /history #9201
Merged
Merged
Start to vueify /history #9201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p0psicles
commented
Feb 11, 2021
•
edited
Loading
edited
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
…tory # Conflicts: # medusa/server/api/v2/history.py # themes-default/slim/src/components/history-new.vue # themes-default/slim/src/global-vue-shim.js # themes/dark/assets/js/medusa-runtime.js # themes/dark/assets/js/vendors~date-fns.js # themes/light/assets/js/medusa-runtime.js # themes/light/assets/js/vendors~date-fns.js
re-build runtime.
* indexer_id not set * show removed from library but records in history.
* Add flag to show while loading history
…tory # Conflicts: # themes-default/slim/src/components/history-new.vue # themes-default/slim/src/style/vgt-table.css # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js
…tory # Conflicts: # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js
* Utilize the last-page event to get a new page.
Start with adding columnFilter.
…tory # Conflicts: # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js
I'm not using it
* Cleanup comments
* Removed localStorage.
* Not used
* Save sorting through cookie * Save filter through cookie * Link to show in episodeTitle * Show subtitle provider
…eify-history # Conflicts: # themes-default/slim/yarn.lock # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js
…Medusa into feature/vueify-history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.