Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix download hander failed #9476

Merged
merged 11 commits into from
Apr 27, 2021

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Apr 24, 2021

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@p0psicles p0psicles marked this pull request as ready for review April 27, 2021 14:17
@p0psicles p0psicles merged commit 8dfa74c into develop Apr 27, 2021
@p0psicles p0psicles deleted the feature/fix-download-hander-failed branch April 27, 2021 14:19
@p0psicles p0psicles added this to the 0.5.12 milestone Apr 27, 2021
@marceloid
Copy link

Hi, first of all I'm very new to Open Source, so excuse any mistake.

Describe the bug
This PR introduced this line of code on lines 311-312 on medusa/clients/torrent/generic.py.

if not self.response:
            return False, 'Unable to connect to {name}'.format(name=self.name)

After this PR, when I fill all the fields on Search settings > Torrents search and click "Test connection", the message "Unable to connect to transmission" appears.

It happens that self.response with self.response.status_code == 409 evalutes to False, so the test_authentication() method returns False. The 409 response occurs because of the need for the X-Transmission-Session-Id header for transmission to return a 200 response.

I've commented these two lines and it worked flawlessly, and the method self.__get_auth() would return self.response.status_code == 200.

I've tested on branch master and develop on commits 8dfa74c and 658c6e8 respectively.

My python version is 3.8.10.

Did I do something wrong or is it a undesirable side effect of the PR?

@p0psicles
Copy link
Contributor Author

I'll add an exception for the 409

@p0psicles p0psicles self-assigned this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants