Start on changes for changeIndexer page. #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added components: - change-indexer.vue - change-indexer-row.vue - select-indexer.vue
Enabled mass updating indexers.
…exers # Conflicts: # medusa/server/core.py # medusa/server/web/manage/handler.py # themes/dark/assets/js/medusa-runtime.js # themes/dark/assets/js/vendors~date-fns.js # themes/light/assets/js/medusa-runtime.js # themes/light/assets/js/vendors~date-fns.js
* Fixed merge conflicts
This is the case when we quickly remove/add a show with existing episodes.
p0psicles
commented
Dec 19, 2021
| ) or ( | ||
| # For example when removing an existing show (keep files) | ||
| # and re-adding it. The status is SKIPPED just after adding it. | ||
| old_status == SKIPPED and not old_location |
There was a problem hiding this comment.
@medariox do you see any issues with adding this option here?
It's this or almost copy all the code from update_status_quality and calling methods, just for changing the indexer.
As it stands now. After re-adding a show, the episodes of the show start with the status "SKIPPED". And this causes it to get the status "ARCHIVED". WHich is incorrect.
…exers # Conflicts: # themes-default/slim/src/components/new-show.vue # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is based on the DEVELOP branch
Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
Read the contribution guide
frontend
backend (api)
connect the two