Don't check if folders are empty for move instead of copy #9950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medariox
commented
Oct 15, 2021
| @@ -406,7 +406,7 @@ def process(self, resource_name=None, force=False, is_priority=None, delete_on=F | |||
| self.log_and_output('Missed file: {missed_file}', level=logging.WARNING, **{'missed_file': missed_file}) | |||
|
|
|||
| if all([app.USE_TORRENTS, app.TORRENT_SEED_LOCATION, | |||
| self.process_method in ('hardlink', 'symlink', 'reflink', 'copy')]): | |||
| self.process_method in ('hardlink', 'symlink', 'reflink', 'keeplink', 'copy')]): | |||
There was a problem hiding this comment.
Just added the keeplink because it is added here, meaning it would never get removed from the list otherwise.
Medusa/medusa/post_processor.py
Lines 1316 to 1322 in 25e7b60
medariox
commented
Oct 15, 2021
| check_empty = False if self.process_method == 'copy' else True | ||
| if self.delete_folder(path, check_empty=check_empty): | ||
| if not app.NO_DELETE and os.path.normpath(path) != os.path.normpath(app.TV_DOWNLOAD_DIR): | ||
| if self.delete_folder(path, check_empty=False): |
There was a problem hiding this comment.
I guess this is what is really meant here... I may be wrong, but it makes most sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only way this makes sense to me. I don't know why we should delete any files on copy? Quite confusing.