Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move replace to FrozenModel #104

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

tlambert03
Copy link
Member

this moves the replace method to the frozen base model, and removes the kwargs from the signature

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (a904ae3) 96.34% compared to head (329d1a4) 96.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   96.34%   96.33%   -0.01%     
==========================================
  Files          12       12              
  Lines         738      736       -2     
==========================================
- Hits          711      709       -2     
  Misses         27       27              
Impacted Files Coverage Δ
src/useq/_base_model.py 88.31% <100.00%> (+0.47%) ⬆️
src/useq/_mda_sequence.py 98.34% <100.00%> (-0.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 merged commit de02308 into pymmcore-plus:main Jul 20, 2023
@tlambert03 tlambert03 deleted the move-replace branch July 20, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant