Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change action type hint on MDAEvent #108

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

tlambert03
Copy link
Member

cc @fdrgsp,
I realized we do actually need to use Union types on MDAEvent.action.

this fixes it

@tlambert03 tlambert03 enabled auto-merge (squash) July 27, 2023 16:01
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (e50aa35) 96.35% compared to head (61ddd5b) 96.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   96.35%   96.36%   +0.01%     
==========================================
  Files          12       12              
  Lines         714      716       +2     
==========================================
+ Hits          688      690       +2     
  Misses         26       26              
Files Changed Coverage Δ
src/useq/_actions.py 100.00% <100.00%> (ø)
src/useq/_mda_event.py 86.44% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 5090e6e into pymmcore-plus:main Jul 27, 2023
20 checks passed
@tlambert03 tlambert03 deleted the change-action-hint branch July 27, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant