Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use pydantic-compat library #124

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

tlambert03
Copy link
Member

I pulled out most of the pydantic cross-compatibility stuff that I added in #122 (along with stuff I did for ome-types and psygnal), and make a new library: https://github.com/tlambert03/pydantic-compat

this PR uses it and pulls out most of the patch logic here

@tlambert03 tlambert03 marked this pull request as ready for review August 1, 2023 17:46
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (91fb059) 98.28% compared to head (fb478df) 98.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   98.28%   98.39%   +0.10%     
==========================================
  Files          15       15              
  Lines         877      811      -66     
==========================================
- Hits          862      798      -64     
+ Misses         15       13       -2     
Files Changed Coverage Δ
src/useq/__init__.py 100.00% <100.00%> (ø)
src/useq/_base_model.py 100.00% <100.00%> (ø)
src/useq/_grid.py 100.00% <100.00%> (ø)
src/useq/_hardware_autofocus.py 100.00% <100.00%> (ø)
src/useq/_iter_sequence.py 100.00% <100.00%> (ø)
src/useq/_mda_event.py 87.50% <100.00%> (+0.26%) ⬆️
src/useq/_mda_sequence.py 98.65% <100.00%> (-0.01%) ⬇️
src/useq/_pydantic_compat.py 100.00% <100.00%> (+3.70%) ⬆️
src/useq/_utils.py 98.38% <100.00%> (-0.03%) ⬇️
src/useq/_z.py 98.43% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 6fa9f31 into pymmcore-plus:main Aug 1, 2023
21 checks passed
@tlambert03 tlambert03 deleted the pydantic-compat branch August 1, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant