Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove __str__ method on MDASequence #136

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

tlambert03
Copy link
Member

closes #135

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (8eca3d3) 98.29% compared to head (bc7de0f) 98.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   98.29%   98.28%   -0.01%     
==========================================
  Files          14       14              
  Lines         880      877       -3     
==========================================
- Hits          865      862       -3     
  Misses         15       15              
Files Changed Coverage Δ
src/useq/_mda_sequence.py 98.63% <ø> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 1f0bff7 into pymmcore-plus:main Sep 22, 2023
@tlambert03 tlambert03 deleted the rm-str branch September 22, 2023 11:27
fdrgsp pushed a commit to fdrgsp/useq-schema that referenced this pull request Sep 24, 2023
tlambert03 added a commit that referenced this pull request Sep 26, 2023
* fix: ValueError also for GridWidthHeight

* ci(dependabot): bump actions/checkout from 3 to 4 (#134)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* refactor: remove __str__ method on MDASequence (#136)

* test: add napari-micromanager test (#139)

* test: add napari-micro test

* ci: fix deps

* test: fix

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Talley Lambert <talley.lambert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo: remove __str__ on mdasequence
1 participant