Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make af-device name optional #145

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Sep 26, 2023

closes #141 by allowing both autofocus device name and offset to be None.
If name is not provided, engines are allowed to simply "apply the offset" as best fits the current hardware (usually, there is only one way to do it at any given time anyway). If offset is None, then the presence of a Hardware Autofocus event simply means "turn on the autofocus without worrying about offset".

see related pymmcore-plus/pymmcore-plus#270

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (17e6533) 98.28% compared to head (da4c3a6) 98.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          14       14           
  Lines         877      877           
=======================================
  Hits          862      862           
  Misses         15       15           
Files Coverage Δ
src/useq/_actions.py 100.00% <100.00%> (ø)
src/useq/_hardware_autofocus.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fdrgsp fdrgsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!!!

@tlambert03 tlambert03 merged commit c609e8a into pymmcore-plus:main Sep 26, 2023
22 checks passed
@tlambert03 tlambert03 deleted the af-optional branch September 26, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making autofocus_device_name optional
2 participants