feat: few updates for WellPlatePlan #171
Conversation
|
|
||
| rows: int | ||
| columns: int | ||
| well_spacing: Tuple[float, float] # (x, y) | ||
| well_size: Union[Tuple[float, float], None] = None # (x, y) | ||
| well_size: Tuple[float, float] # (width, height) |
There was a problem hiding this comment.
my reasoning for making this optional was that it's only necessary if you want to take a few images per well within some area. It's obviously pretty important in that case... but if you just wanted to take one image per well it's not necessary. I do guess in that case someone could just put in a fake number if they don't care about where the edge of the well is? (I do see that it makes life harder elsewhere if you can't rely on it)
fine with me to make it required though
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 98.28% 95.71% -2.57%
==========================================
Files 14 15 +1
Lines 874 1050 +176
==========================================
+ Hits 859 1005 +146
- Misses 15 45 +30 ☔ View full report in Codecov by Sentry. |
@tlambert03 these are few updates I think might be useful.
GridPosition+ updatePositionwell_sizerequiredI also added a test to check the serialization because I was getting something weird when working on the
HCSWizardwidget. Basically if you create aWellPlatePlanfrom adict, thewell_points_planis alwaysPosition()no matter what you pass and I don't yet understand why...