Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename tile to grid #76

Closed
wants to merge 48 commits into from

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Jan 27, 2023

This PR changes the name of the tiles object in grid (e.g. TileFromCorners -> GridFromCorners)

merge after #75

tests are failing because of 0.34% difference.

fdrgsp and others added 30 commits January 22, 2023 14:05
Co-authored-by: Talley Lambert <talley.lambert@gmail.com>
suggestions for tile plan refactor
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 93.46% // Head: 93.12% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (c316f56) compared to base (61a2333).
Patch coverage: 95.13% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   93.46%   93.12%   -0.34%     
==========================================
  Files          10       10              
  Lines         551      582      +31     
==========================================
+ Hits          515      542      +27     
- Misses         36       40       +4     
Impacted Files Coverage Δ
src/useq/_grid.py 94.57% <94.57%> (ø)
src/useq/__init__.py 100.00% <100.00%> (ø)
src/useq/_mda_sequence.py 92.61% <100.00%> (-2.72%) ⬇️
src/useq/_position.py 96.42% <100.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 closed this Jan 30, 2023
@fdrgsp fdrgsp deleted the rename_tile_to_grid branch February 2, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants