Write_registers/pdu typing again. (#2468)

examples/client_async.py

@@ -48,7 +48,7 @@
 _logger.setLevel("DEBUG")
 
 
-def setup_async_client(description=None, cmdline=None):
+def setup_async_client(description: str | None =None, cmdline: str | None = None) -> modbusClient.ModbusBaseClient:
     """Run client setup."""
     args = helper.get_commandline(
         server=False, description=description, cmdline=cmdline

examples/client_async_calls.py

@@ -34,6 +34,7 @@
 import sys
 
 from pymodbus import ModbusException
+from pymodbus.client import ModbusBaseClient
 from pymodbus.pdu import FileRecord
 
 
@@ -157,19 +158,17 @@ async def async_handle_holding_registers(client):
     assert not rr.isError()  # test that call was OK
     assert rr.registers == arguments["values"]
 
-async def async_write_registers_mypy(client):
+async def async_write_registers_mypy(client: ModbusBaseClient) -> None:
     """Read/write holding registers."""
     regs1: list[int] = [10] * 8
     await client.write_registers(1, regs1, slave=SLAVE)
     rr = await client.read_holding_registers(1, count=len(regs1), slave=SLAVE)
     assert not rr.isError()  # test that call was OK
-    assert rr.registers == regs1
 
     regs2: list[bytes] = [b'\x01\x02', b'\x03\x04']
     await client.write_registers(1, regs2, slave=SLAVE)
     rr = await client.read_holding_registers(1, count=len(regs2), slave=SLAVE)
     assert not rr.isError()  # test that call was OK
-    assert rr.registers == regs2
 
 
 async def async_handle_input_registers(client):

examples/helper.py

@@ -9,14 +9,15 @@
 import argparse
 import logging
 import os
+from typing import Any
 
 from pymodbus import pymodbus_apply_logging_config
 
 
 _logger = logging.getLogger(__file__)
 
 
-def get_commandline(server=False, description=None, extras=None, cmdline=None):
+def get_commandline(server: bool = False, description: str | None = None, extras: Any = None, cmdline: str | None = None):
     """Read and validate command line arguments."""
     parser = argparse.ArgumentParser(description=description)
     parser.add_argument(

pymodbus/client/mixin.py

@@ -2,6 +2,7 @@
 from __future__ import annotations
 
 import struct
+from collections.abc import Sequence
 from enum import Enum
 from typing import Generic, TypeVar
 
@@ -501,7 +502,7 @@ def write_coils(
     def write_registers(
         self,
         address: int,
-        values: list[bytes | int],
+        values: Sequence[int | bytes],
         *,
         slave: int = 1,
         no_response_expected: bool = False
@@ -515,7 +516,9 @@ def write_registers(
         :raises ModbusException:
 
         .. tip::
-            values= entries defined as bytes are silently converted to int !
+            values= parameter:
+            entries defined as bytes are silently converted to int !
+            only list[int], list[bytes] or list[bytes | int] are expected (others may work unsupported)
 
         This function is used to write a block of contiguous registers
         (1 to approx. 120 registers) in a remote device.
@@ -627,7 +630,9 @@ def readwrite_registers(
         :raises ModbusException:
 
         .. tip::
-            values= entries defined as bytes are silently converted to int !
+            values= parameter:
+            entries defined as bytes are silently converted to int !
+            only list[int], list[bytes] or list[bytes | int] are expected (others may work unsupported)
 
         This function performs a combination of one read operation and one
         write operation in a single MODBUS transaction. The write

pymodbus/datastore/simulator.py

@@ -106,10 +106,10 @@ class Setup:
     :meta private:
     """
 
-    def __init__(self, runtime):
+    def __init__(self, runtime: Any) -> None:
         """Initialize."""
         self.runtime = runtime
-        self.config = {}
+        self.config: Any = {}
         self.config_types: dict[str, dict[str, Any]] = {
             Label.type_bits: {
                 Label.type: CellType.BITS,

pymodbus/pdu/pdu.py

@@ -4,6 +4,7 @@
 import asyncio
 import struct
 from abc import abstractmethod
+from collections.abc import Sequence
 from typing import cast
 
 from pymodbus.exceptions import NotImplementedException
@@ -24,7 +25,7 @@ def __init__(self,
             address: int = 0,
             count: int = 0,
             bits: list[bool] | None = None,
-            registers: list[int] | list[bytes] | list[bytes | int] | None = None,
+            registers: Sequence[bytes | int] | None = None,
             status: int = 1,
         ) -> None:
         """Initialize the base data for a modbus request."""