1. Fix sync client and examples.

2. Fix repl server errors

examples/client_async_basic_calls.py

@@ -22,21 +22,21 @@ async def handle_coils(client):
     _logger.debug(txt)
 
     _logger.info("### Reading Coils to get bit 5")
-    rr = await client.read_coils(1, 5)
+    rr = await client.read_coils(1, 5, unit=UNIT)
     assert not rr.isError()  # test that call was OK
     txt = f"### coils response: {str(rr.bits)}"
     _logger.debug(txt)
 
     _logger.info("### Write true to coil bit 0 and read to verify")
-    rq = await client.write_coil(0, True)
-    rr = await client.read_coils(0, 1)
+    rq = await client.write_coil(0, True, unit=UNIT)
+    rr = await client.read_coils(0, 1, unit=UNIT)
     assert not rq.isError() and not rr.isError()  # test that calls was OK
     assert rr.bits[0]  # test the expected value
     txt = f"### coils response: {str(rr.bits)}"
     _logger.debug(txt)
 
     _logger.info("### Write true to multiple coils 1-8")
-    rq = await client.write_coils(1, [True] * 8, unit=UNIT)
+    rq = await client.write_coils(1, [True] * 21, unit=UNIT)
     rr = await client.read_coils(1, 21, unit=UNIT)
     assert not rq.isError() and not rr.isError()  # test that calls was OK
     resp = [True] * 21

examples/client_sync.py

@@ -44,7 +44,6 @@
 def setup_sync_client():
     """Run client setup."""
     args = get_commandline()
-    args.comm = "serial"
     _logger.info("### Create client object")
     if args.comm == "tcp":
         client = ModbusTcpClient(

examples/client_sync_basic_calls.py

@@ -20,21 +20,21 @@ def handle_coils(client):
     _logger.debug(txt)
 
     _logger.info("### Reading Coils to get bit 5")
-    rr = client.read_coils(1, 5)
+    rr = client.read_coils(1, 5, unit=UNIT)
     assert not rr.isError()  # test that call was OK
     txt = f"### coils response: {str(rr.bits)}"
     _logger.debug(txt)
 
     _logger.info("### Write true to coil bit 0 and read to verify")
-    rq = client.write_coil(0, True)
-    rr = client.read_coils(0, 1)
+    rq = client.write_coil(0, True, unit=UNIT)
+    rr = client.read_coils(0, 1, unit=UNIT)
     assert not rq.isError() and not rr.isError()  # test that calls was OK
     assert rr.bits[0]  # test the expected value
     txt = f"### coils response: {str(rr.bits)}"
     _logger.debug(txt)
 
     _logger.info("### Write true to multiple coils 1-8")
-    rq = client.write_coils(1, [True] * 8, unit=UNIT)
+    rq = client.write_coils(1, [True] * 21, unit=UNIT)
     rr = client.read_coils(1, 21, unit=UNIT)
     assert not rq.isError() and not rr.isError()  # test that calls was OK
     resp = [True] * 21

pymodbus/repl/server/main.py

@@ -3,9 +3,10 @@
 import asyncio
 import json
 import logging
+import typer
+from typing import List
 from pathlib import Path
 from enum import Enum
-import typer
 from pymodbus.framer.socket_framer import ModbusSocketFramer
 from pymodbus.repl.server.cli import run_repl
 from pymodbus.server.reactive.default_config import DEFUALT_CONFIG
@@ -45,7 +46,7 @@ class ModbusFramerTypes(str, Enum):
     binary = "binary"  # pylint: disable=invalid-name
 
 
-def _completer(incomplete: str, valid_values: list[str]) -> list[str]:
+def _completer(incomplete: str, valid_values: List[str]) -> List[str]:
     """Complete value."""
     completion = []
     for name in valid_values:
@@ -54,13 +55,13 @@ def _completer(incomplete: str, valid_values: list[str]) -> list[str]:
     return completion
 
 
-def framers(incomplete: str) -> list[str]:
+def framers(incomplete: str) -> List[str]:
     """Return an autocompleted list of supported clouds."""
     _framers = ["socket", "rtu", "tls", "ascii", "binary"]
     return _completer(incomplete, _framers)
 
 
-def servers(incomplete: str) -> list[str]:
+def servers(incomplete: str) -> List[str]:
     """Return an autocompleted list of supported clouds."""
     _servers = ["tcp", "serial", "tls", "udp"]
     return _completer(incomplete, _servers)
@@ -128,7 +129,7 @@ def run(
         "--modbus-port",
         "-p",
         help='Modbus port'),
-    modbus_unit_id: list[int] = typer.Option(
+    modbus_unit_id: List[int] = typer.Option(
         None,
         "--unit-id",
         "-u",

pymodbus/transaction.py

@@ -281,7 +281,7 @@ def _transact(
         """
         last_exception = None
         try:
-            self.client.connect()
+            self.client.start()
             packet = self.client.framer.buildPacket(packet)
             if _logger.isEnabledFor(logging.DEBUG):
                 txt = f"SEND: {hexlify_packets(packet)}"