BUG: handle_local_echo not working

[Iktek]

Dear List,
On current dev version there seems to be a bug with "handle_local_echo".
The attribute is pushed to the base-clients "comm_params" variable in base.py.

Transaction.py nevertheless tries to find it in the base of the client class:

hasattr(self.client, "handle_local_echo")

This seems wrong.
When I change transaction.py like:

--- transaction.py.old  2023-08-07 09:50:09.485911612 +0200
+++ transaction.py      2023-08-07 09:42:42.276994370 +0200
@@ -311,8 +311,8 @@ class ModbusTransactionManager:
                 )
                 self.client.state = ModbusTransactionState.WAITING_FOR_REPLY
             if (
-                hasattr(self.client, "handle_local_echo")
-                and self.client.handle_local_echo is True
+                hasattr(self.client.comm_params, "handle_local_echo")
+                and self.client.comm_params.handle_local_echo is True
             ):
                 if self._recv(size, full) != packet:
                     return b"", "Wrong local echo"

The functionality seems to work again.

[janiversen]

Looks like a bug, please submit a pull request