Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi do not like repl. #2069

Closed
janiversen opened this issue Mar 3, 2024 · 6 comments · Fixed by #2077
Closed

pypi do not like repl. #2069

janiversen opened this issue Mar 3, 2024 · 6 comments · Fixed by #2077
Assignees

Comments

@janiversen
Copy link
Collaborator

In order to get v3.6.5 uploaded, I had to modify pyproject.toml:

#repl = [
#   "pymodbus-repl@git+https://github.com/pymodbus-dev/repl"
#]

pypi do not like direct links (whatever that means).

@dhoomakethu
Copy link
Contributor

Is the error while uploading the package or during the build?

@janiversen
Copy link
Collaborator Author

While doing "twine upload", strange enough "twine check" did not report any problems.

build works fine.

@dhoomakethu
Copy link
Contributor

Will try to reproduce, thanks

@dhoomakethu
Copy link
Contributor

Will be pushing version pymodbus. 3.7.0.dev0 to pypi for testing purpose. Will be yanked later. cc @janiversen

@janiversen
Copy link
Collaborator Author

Ok no problem.

@dhoomakethu
Copy link
Contributor

pymodbus on  2069-pypi-do-not-like-repl [$!?] via 🐍 v3.8.13 (pymodbus)
❯ twine check dist/*
Checking dist/pymodbus-3.7.0.dev0-py3-none-any.whl: PASSED
Checking dist/pymodbus-3.7.0.dev0.tar.gz: PASSED

pymodbus on  2069-pypi-do-not-like-repl [$!?] via 🐍 v3.8.13 (pymodbus)
❯ twine upload -r pymodbus dist/*
Uploading distributions to https://upload.pypi.org/legacy/
Uploading pymodbus-3.7.0.dev0-py3-none-any.whl
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 206.3/206.3 kB • 00:01 • 260.1 kB/s
Uploading pymodbus-3.7.0.dev0.tar.gz
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 211.9/211.9 kB • 00:00 • 49.1 MB/s

View at:
https://pypi.org/project/pymodbus/3.7.0.dev0/

dhoomakethu added a commit that referenced this issue Mar 5, 2024
@dhoomakethu dhoomakethu linked a pull request Mar 5, 2024 that will close this issue
janiversen added a commit that referenced this issue Mar 5, 2024
Co-authored-by: jan iversen <jancasacondor@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants