Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ModbusClientMixin Generic to fix type issues for sync and async #1980

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Make ModbusClientMixin Generic to fix type issues for sync and async #1980

merged 8 commits into from
Feb 9, 2024

Commits on Feb 8, 2024

  1. make client typehints generic so that concrete client can decide on a… 

    …waitable vs sync
    Laurin Schmidt committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    af6630a View commit details
    Browse the repository at this point in the history

  2. fix unused typevar

    Laurin Schmidt committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ba73674 View commit details
    Browse the repository at this point in the history

  3. remove mixin init, ignore async bytes return

    Laurin Schmidt committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    aee85b8 View commit details
    Browse the repository at this point in the history

  4. more type error fix attempts

    Laurin Schmidt committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c89124d View commit details
    Browse the repository at this point in the history

  5. add back mixin init

    Laurin Schmidt committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c7dd2fb View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. more thorough mixin test

    @alexrudd2
    alexrudd2 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    264444c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into correct_client_hints

    @janiversen
    janiversen authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    7407919 View commit details
    Browse the repository at this point in the history

  3. Update mixin.py

    @janiversen
    janiversen authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6222e07 View commit details
    Browse the repository at this point in the history