Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DictTransactionManager -> ModbusTransactionManager #2042

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

alexrudd2
Copy link
Collaborator

After #1966, there is only DictTransactionManager.

It can be combined with the base class.

@alexrudd2 alexrudd2 marked this pull request as draft February 21, 2024 17:44
@alexrudd2 alexrudd2 marked this pull request as ready for review February 21, 2024 17:51
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit ae266cf into dev Feb 22, 2024
1 check passed
@janiversen janiversen deleted the remove-dict-tm branch February 22, 2024 07:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants