Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves 8 more
mypy
errors, including a real problem inModbusSparseDataBlock
.The method
default()
(inherited fromModbusBaseDataBlock
) does not make any sense for a sparse datastore, whereself.values
is a dictionary. If called, it will break the implementation.==> Move it to
ModbusSequentialDataBlock
.Also,
reset()
is defined inModbusBaseDataBlock
but overridden byModbusSparseDataBlock
.==> Move it also to
ModbusSequentialDataBlock
.