New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve payload types #2057

Merged

janiversen merged 1 commit into dev from types-payload

Feb 25, 2024

Collaborator

alexrudd2 commented Feb 24, 2024

Solve another 5 mypy errors in pymodbus.payload.

Should also be a tiny perfomance boost due to reducing allocations.


          Improve payload types

b4044d6

janiversen approved these changes

View reviewed changes

Collaborator

janiversen left a comment

LGTM, thanks.

Payload should later be changed to work with mixin, so you e.g can do read_holding and get int32 directly

janiversen merged commit 52cb60b into dev

1 check passed

janiversen deleted the types-payload branch

February 25, 2024 06:59

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet