Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve factory types #2060

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Improve factory types #2060

merged 2 commits into from
Feb 25, 2024

Conversation

alexrudd2
Copy link
Collaborator

Unfortunately mypy is not smart enough to understand the Request/Response lists, so use type: ignore

Solves another 11 mypy errors.



janiversen
janiversen approved these changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh...finally you also saw a limit of mypy :-)

LGTM, thanks.

Ps. Please do a rebase, seems you are a bit behind.

@janiversen janiversen merged commit 6029f38 into dev Feb 25, 2024
1 check passed
@janiversen janiversen deleted the factory-types branch February 25, 2024 20:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen