Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve simulator types #2076

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Improve simulator types #2076

merged 1 commit into from
Mar 4, 2024

Conversation

alexrudd2
Copy link
Collaborator

Solve another 9 mypy errors with --check-untyped-defs

janiversen
janiversen approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 23760b7 into dev Mar 4, 2024
1 check passed
@janiversen janiversen deleted the simulator-types branch March 4, 2024 07:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen