Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is straightforward.
For the second one,
mypy
complains that we are passingasyncio.CancelledError
toclose
which only takesException
. As of Python 3.8asyncio.CancelledError
is dervied fromBaseException
instead. It will therefore not be caught or suppressed by anything acting onException
.pymodbus/pymodbus/transport/serialtransport.py
Lines 53 to 55 in 7c4a310
I don't see any use in passing it, so I just used
None
. The alternative is to justtype: ignore