Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mock.patch.object to avoid protected access errors. #2251

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Use mock.patch.object to avoid protected access errors. #2251

merged 1 commit into from
Jul 21, 2024

Conversation

jameshilliard
Copy link
Contributor

This seems to be cleaner and play better with mypy.

@jameshilliard jameshilliard mentioned this pull request Jul 20, 2024
Closed
janiversen
janiversen approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute, it even makes the code more compact.

@janiversen janiversen merged commit fbaf05d into pymodbus-dev:dev Jul 21, 2024
1 check passed
@jameshilliard jameshilliard deleted the dev_test_transaction branch July 21, 2024 06:26
@janiversen janiversen mentioned this pull request Jul 22, 2024
Closed
@alexrudd2
Copy link
Collaborator

Agreed, it's a clean and easy to understand pattern, and removes a lot of pylint noise too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameshilliard @alexrudd2 @janiversen