Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic GitHub actions workflow #20

Merged
merged 6 commits into from
Sep 15, 2024
Merged

Add basic GitHub actions workflow #20

merged 6 commits into from
Sep 15, 2024

Conversation

alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Aug 8, 2024

Progress towards #3. This adds ruff ,mypy, and pytest. (but doesn't do any fancy caching like #9)

Note this is based off the ruff branch because main currently has lint and type errors.

@alexrudd2 alexrudd2 requested a review from dhoomakethu August 8, 2024 14:28
@dhoomakethu
Copy link
Contributor

Does this supersede #19 ? I see similar changes here as well.

@alexrudd2
Copy link
Collaborator Author

Does this supersede #19 ? I see similar changes here as well.

No, it simply includes those earlier commits because it's based off that branch.

@dhoomakethu
Copy link
Contributor

@alexrudd2 , Are these jobs expected to fail?

@alexrudd2
Copy link
Collaborator Author

No, they were passing when I made the PR but something broke with poetry. I'll look into it; should be an easy fix

@dhoomakethu dhoomakethu merged commit dd8ec1a into main Sep 15, 2024
4 checks passed
@dhoomakethu
Copy link
Contributor

closes #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants