Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise error when there are no argument completions #6

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

alexrudd2
Copy link
Collaborator

Partially pymodbus-dev/pymodbus#2008 (from the original repo)

Argument completions still do not work, but at least it fails gracefully instead of raising an Exception

@dhoomakethu
Copy link
Contributor

Will be merged once the other 2 PR's are sorted.

@dhoomakethu dhoomakethu merged commit dc3ae8c into main Feb 19, 2024
@alexrudd2 alexrudd2 deleted the arg-completions branch February 20, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants