Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuropixels loader #1

Merged
merged 17 commits into from
Sep 28, 2023
Merged

Neuropixels loader #1

merged 17 commits into from
Sep 28, 2023

Conversation

slcalgin
Copy link
Contributor

Hi Guillaume
Here is the Allen Neuropixels loader. I fixed the bug with the manifest file, but will continue testing it on other devices to ensure smooth workflow.

Copy link
Contributor

@gviejo gviejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a minimal working example and some test in /tests?
Can it run outside a notebook btw?

nwbmatic/allends.py Show resolved Hide resolved
@slcalgin
Copy link
Contributor Author

Hi Guillaume,
For sure, can do that.
And yes, it should work outside a notebook, I've run it on the terminal multiple times. What would be the reason it would not run outside a notebook? I'm not familiar.

@gviejo
Copy link
Contributor

gviejo commented Sep 14, 2023

I tried on my workstation and it was idling in the terminal. I couldn't figure out why.

@slcalgin
Copy link
Contributor Author

Hm. Weird. It does take quite a bit (a few minutes) to load for the first time

session_dropdown["values"] = type2_sessions

def ok_button_click():
global session_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove global session_id

slcalgin and others added 3 commits September 28, 2023 16:03
slcalgin and others added 2 commits September 28, 2023 16:34
@gviejo gviejo merged commit cae4844 into pynapple-org:main Sep 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants