Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to relative links #348

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Change to relative links #348

merged 4 commits into from
Oct 2, 2024

Conversation

BalzaniEdoardo
Copy link
Collaborator

Change all internal links to relative.

This solve the following issue:

One can break a link by changing the site folder structure but pass the CI. Here is why:

  1. When the CI runs, absolute link will still works, because the external links are still fine (the website is not built yet)
  2. The code is merged and the website is built; now the absolute link is broken
  3. If you re-run the CI it would fail

@BalzaniEdoardo BalzaniEdoardo requested a review from gviejo as a code owner October 2, 2024 16:25
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@gviejo gviejo merged commit 3313117 into dev Oct 2, 2024
13 checks passed
@gviejo gviejo deleted the change_to_relative_links branch October 2, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants