Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reqwest #222

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Update reqwest #222

merged 1 commit into from
Apr 7, 2024

Conversation

Tiwalun
Copy link
Contributor

@Tiwalun Tiwalun commented Mar 23, 2024 •
edited
Loading

And updating reqwest removes a duplicate dep in probe-rs.

@Tiwalun
Copy link
Contributor Author

Tiwalun commented Mar 24, 2024

The update to minidom v0.13 means that XML elements are required to have a namespace, which breaks the tests. That requires some more work to fix, so I've removed from this PR.

@Tiwalun Tiwalun changed the title Update reqwest and minidom deps Update reqwest ~~and minidom deps~~ Mar 24, 2024
@Tiwalun Tiwalun changed the title Update reqwest ~~and minidom deps~~ Update reqwest Mar 24, 2024
@mathias-arm
Copy link
Collaborator

I rebased and squashed your PR (your old branch is saved at https://github.com/mbrossard/cmsis-pack-manager/tree/update-deps). I found the same issue with minidom.

@mathias-arm mathias-arm merged commit 3ebce2f into pyocd:main Apr 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tiwalun @mathias-arm