Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test (dupplicated PR) gdbserver: be stricter about qC #1705

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test (dupplicated PR) gdbserver: be stricter about qC #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42c563e
gdbserver: be stricter about qC
tlyu Jan 12, 2024
287c512
ci: exclude python 3.7 on macos
ithinuel Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/basic_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:
- "3.9"
- "3.10"
- "3.11"
exclude:
- os: macos-latest
python-version: "3.7"

steps:
# Only check out HEAD. We don't need the full history.
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/basic_test_skipped.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@ jobs:
- "3.9"
- "3.10"
- "3.11"
exclude:
- os: macos-latest
python-version: "3.7"
steps:
- run: 'echo "Skipped due to path filter."'
2 changes: 1 addition & 1 deletion pyocd/gdbserver/gdbserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ def handle_query(self, msg):
# Must return an empty packet for an unrecognized qXfer.
return self.create_rsp_packet(b"")

elif query[0].startswith(b'C'):
elif query[0] == b'C':
if not self.is_threading_enabled():
return self.create_rsp_packet(b"QC1")
else:
Expand Down
Loading