Fix pyocd flash error for invalid file #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial check if the file path is valid. If not, FileNotFoundError is raised. - Explicit check for no file extension if file_format is not set. - Defined file_obj local var prior to try/finally and check that it's not None before closing it. - Added FileNotFoundError class for Py2 to pyocd.utility.compatibilty.
|
/morph test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
pyocd flashwith an invalid path you'd get a less than helpful exception aboutfile_objnot being defined. This PR reworksFileProgrammererror checking soFileNotFoundErroris raised if the given path is invalid. A couple other issues are also addressed, including the cause of thefile_objexception.Closes #590