Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release the netcdf4 version #72

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 21, 2023

Nothing to see here, just debugging this...

@ocefpaf ocefpaf marked this pull request as ready for review March 21, 2023 18:24
@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 21, 2023

@kwilcox it turns out this was easier to fix them I expected. It was unrelated to the GIL release in 1.6.1 but due to Unidata/netcdf-c#2231 in the upstream c-lib.

This is ready for review and I'd love to get this one and #71 in for a new release.

@ocefpaf ocefpaf mentioned this pull request Mar 21, 2023
@ocefpaf ocefpaf changed the title release the version release the netcdf4 version Mar 21, 2023
@kwilcox
Copy link
Member

kwilcox commented Mar 21, 2023

Glad this ended up being a clean fix!

@kwilcox kwilcox self-assigned this Mar 21, 2023
@kwilcox kwilcox self-requested a review March 21, 2023 19:12
pocean/utils.py Outdated Show resolved Hide resolved
@kwilcox kwilcox merged commit 9a06856 into pyoceans:main Mar 21, 2023
@ocefpaf ocefpaf deleted the debug_netcdf4_version branch March 21, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants