Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to pydantic <2 #23

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Pin to pydantic <2 #23

merged 3 commits into from
Sep 27, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Sep 27, 2023 •
edited
Loading

References

Changes

  • adds pydantic pin in pyproject.toml
  • use pydantic 1.x API
    • model dumping
    • use nested Config class instead of ConfigDict
  • fix tests
    • more model dumping
    • update magic strings
  • changelog

@bollwyvl bollwyvl marked this pull request as ready for review September 27, 2023 14:09
rth
rth approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bollwyvl . Minor comment otherwise LGTM.

pyproject.toml Outdated
@@ -11,7 +11,8 @@ description = "Tooling to manage the `pyodide-lock.json` file"
readme = "README.md"
requires-python = ">=3.10"
dependencies = [
"pydantic"
# compatible with pyodide-build, and the as-shipped wheel in the pyodide distributiont
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos after the the ","

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what you mean by "as-shipped wheel" but it's probably just me :) Fine to merge as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feller: https://github.com/pyodide/pyodide/blob/main/packages/pydantic/meta.yaml

@rth rth merged commit 92e9511 into pyodide:main Sep 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin to pydantic <2
2 participants
@bollwyvl @rth