Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/group 4 #169

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Patch/group 4 #169

merged 3 commits into from
Jan 30, 2019

Conversation

dirtycajunrice
Copy link
Member

No description provided.

@dirtycajunrice dirtycajunrice added bug Something isn't working cleanup cleaning up/removing stale or old code labels Jan 29, 2019
circa10a
circa10a reviewed Jan 30, 2019
View reviewed changes
pyouroboros/dockerclient.py
if self.config.docker_tls:
try:
cert_paths = {
'cert_top_dir': '/etc/docker/certs.d/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So will this be a default location that we'll document where to mount certs?

@dirtycajunrice dirtycajunrice merged commit eabf4a8 into develop Jan 30, 2019
@dirtycajunrice dirtycajunrice deleted the patch/group-4 branch January 30, 2019 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circa10a circa10a circa10a approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cleanup cleaning up/removing stale or old code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirtycajunrice @circa10a