Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all services by default on swarm mode #228

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Check all services by default on swarm mode #228

merged 1 commit into from
Feb 20, 2019

Conversation

mathcantin
Copy link
Contributor

Why in the default mode, all containers are check by default and on the swarm mode we need to add labels by default?

That PR standardize the behavior between normal and swarm mode.

@dirtycajunrice
Copy link
Member

This was ARBITRARILY intentional with the thought process of "if they are using swarm, they should need to use labels". You disagree?

@mathcantin
Copy link
Contributor Author

No, because there are actually no way to activate auto update for all existing and futur services, we need to add label on every services.

We could create a negative flag like "--no-labels", but that make options harder to understand. I think it's better to reuse existing options.

@dirtycajunrice
Copy link
Member

swarm == enterprise. if people arent readily putting labels on their services i feel like theres a bigger issue ya know?

@mathcantin
Copy link
Contributor Author

Yes, it's true in production, but I think there are good use case in development or staging to enable on every services.

@nightvisi0n
Copy link
Contributor

on the swarm mode we need to add labels by default?

I'm not aware of that. AFAIK you can use swarm without labels very well.

Copy link
Member

@dirtycajunrice dirtycajunrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. Ill put it for now. I dont see the issue. It was only removed as an opinion

@dirtycajunrice dirtycajunrice merged commit c76a0f7 into pyouroboros:develop Feb 20, 2019
@dirtycajunrice dirtycajunrice added the cleanup cleaning up/removing stale or old code label Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup cleaning up/removing stale or old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants