Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py #40

Merged
merged 2 commits into from
Oct 28, 2018
Merged

Add setup.py #40

merged 2 commits into from
Oct 28, 2018

Conversation

tlkamp
Copy link
Contributor

@tlkamp tlkamp commented Oct 27, 2018

This PR makes ouroboros installable by pip. When ouroboros is installed by pip, ouroboros is available in the user's path.

There should be no notable difference in the documentation.

run_tests.sh still works.

Closes #28

@codecov-io
Copy link

Codecov Report

Merging #40 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   96.35%   96.42%   +0.07%     
==========================================
  Files           7        7              
  Lines         137      140       +3     
==========================================
+ Hits          132      135       +3     
  Misses          5        5
Impacted Files Coverage Δ
ouroboros/logger.py 100% <ø> (ø) ⬆️
ouroboros/ouroboros 100% <100%> (ø)
ouroboros/cli.py 100% <100%> (ø) ⬆️
ouroboros/main.py 86.66% <100%> (-3.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5bfb3b...cd5fa84. Read the comment docs.

@circa10a
Copy link
Member

Should we modify the Travis build to push to pypi as well?

@tlkamp
Copy link
Contributor Author

tlkamp commented Oct 27, 2018

We could! Never done that before. Have you?

This also might be a major version bump.

@circa10a
Copy link
Member

Yeah I have, It should actually still be in the history of the .travis.yml.
I'll see about getting it in there later on. At an event at the moment

@circa10a
Copy link
Member

Also will need to update deploy.sh to get the package version from setup.py instead of init.py

@circa10a circa10a merged commit fda33a6 into pyouroboros:master Oct 28, 2018
@dirtycajunrice dirtycajunrice added the enhancement New feature or request label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants