Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pip cache in Dockerfile #50

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Conversation

strayer
Copy link
Contributor

@strayer strayer commented Nov 10, 2018

It doesn't do much of a difference, but still saves 1MB in the pip install layer.

Without --no-cache-dir:

IMAGE               CREATED             CREATED BY                                      SIZE                COMMENT
4a889526f024        23 seconds ago      /bin/sh -c #(nop)  ENTRYPOINT ["ouroboros"]     0B
fc1bbdc7d8d9        23 seconds ago      /bin/sh -c pip install .                        11.2MB
f52b1822a574        29 seconds ago      /bin/sh -c #(nop) WORKDIR /app                  0B
ff68c7715a92        29 seconds ago      /bin/sh -c #(nop) COPY dir:b7a988c2253999fea…   21.4kB

With --no-cache-dir:

IMAGE               CREATED             CREATED BY                                      SIZE                COMMENT
fc05a396dea7        4 seconds ago       /bin/sh -c #(nop)  ENTRYPOINT ["ouroboros"]     0B
4cfeeb1816ee        4 seconds ago       /bin/sh -c pip install --no-cache-dir .         10.2MB
1d752126f43d        10 seconds ago      /bin/sh -c #(nop) WORKDIR /app                  0B
8ea197c11b15        11 seconds ago      /bin/sh -c #(nop) COPY dir:8a8a1d6ff52947334…   21.4kB

@codecov-io
Copy link

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         149    149           
=====================================
  Hits          149    149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f2749...512e9bb. Read the comment docs.

@circa10a
Copy link
Member

Hey 1mb is 1mb!

Thanks!

@circa10a circa10a merged commit 3be3f47 into pyouroboros:master Nov 10, 2018
@dirtycajunrice dirtycajunrice added the enhancement New feature or request label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants