Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus bind fix, org rename #81

Merged
merged 4 commits into from
Jan 12, 2019
Merged

Prometheus bind fix, org rename #81

merged 4 commits into from
Jan 12, 2019

Conversation

circa10a
Copy link
Member

  • Update docs with new org name
  • Update prometheus addr and bind vars, names to remove _exporter_
  • Fixed bug where prometheus all counter was updated with every pass.
  • Fixed bug where prometheus_addr and prometheus_port were being ignored due to missing comma in Config class.
  • Remove pytest dependencies

dirtycajunrice
dirtycajunrice approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@dirtycajunrice dirtycajunrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@circa10a circa10a merged commit 0ae1ada into master Jan 12, 2019
@circa10a circa10a deleted the prometheus_bind branch January 12, 2019 22:00
@dirtycajunrice dirtycajunrice added the bug Something isn't working label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtycajunrice dirtycajunrice dirtycajunrice approved these changes

@tlkamp tlkamp Awaiting requested review from tlkamp

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circa10a @dirtycajunrice