Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed old test related items, removed the need for duplicate bin sc… #85

Merged
merged 5 commits into from
Jan 13, 2019
Merged

Removed old test related items, removed the need for duplicate bin sc… #85

merged 5 commits into from
Jan 13, 2019

Conversation

circa10a
Copy link
Member

  • Removed tests
  • Testing docs
  • Removed need for having ouroboros and ouroboros.py scripts placed into bin directory

dirtycajunrice
dirtycajunrice reviewed Jan 13, 2019
View reviewed changes
Copy link
Member

@dirtycajunrice dirtycajunrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am certain i tested your ouroboros removing ouroboros.py and it did not work. Do you have it working this way?

@circa10a
Copy link
Member Author

I am certain i tested your ouroboros removing ouroboros.py and it did not work. Do you have it working this way?

Yup, worked perfectly on my end

dirtycajunrice
dirtycajunrice approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@dirtycajunrice dirtycajunrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore me. its golden

@circa10a circa10a merged commit 2e8cbfd into master Jan 13, 2019
@circa10a circa10a deleted the fix_script_imports branch January 13, 2019 06:45
@dirtycajunrice dirtycajunrice added the bug Something isn't working label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtycajunrice dirtycajunrice dirtycajunrice approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circa10a @dirtycajunrice