Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When repairing a pure python wheel, exit code should be 0 #438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdbisme
Copy link

@rdbisme rdbisme commented Jul 13, 2023

No description provided.

@rdbisme
Copy link
Author

rdbisme commented Jul 13, 2023

Based on #47, when doing auditwheel repair on a pure python wheel, the exit code should not be 1.

My use case is that I'm running repair on all the wheel produced by some colleague, and if they're pure python, it makes the CI pipeline to fail.

@rdbisme rdbisme force-pushed the exit-code-pure branch 2 times, most recently from b3c8fc6 to d0c6fa8 Compare July 17, 2023 11:41
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (90d382e) 92.33% compared to head (c57b1df) 92.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files          23       23           
  Lines        1291     1291           
  Branches      302      302           
=======================================
  Hits         1192     1192           
  Misses         57       57           
  Partials       42       42           
Files Changed Coverage Δ
src/auditwheel/main_addtag.py 89.74% <100.00%> (ø)
src/auditwheel/main_repair.py 90.90% <100.00%> (ø)
src/auditwheel/main_show.py 83.05% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy requested review from mayeut and auvipy July 25, 2023 13:12
@mayeut
Copy link
Member

mayeut commented Feb 3, 2024

I'd still want to fail on this one.
How about a specific error code for this case ?

cc @lkollar for another opinion

@rdbisme
Copy link
Author

rdbisme commented Feb 4, 2024

I'd still want to fail on this one. How about a specific error code for this case ?

cc @lkollar for another opinion

That will require special handling in the CI for my use case anyway. Why a noop should exit as a failure? I'd expect for it to not error if there's nothing to do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants