Remove OrderedDict #441
Merged
Remove OrderedDict #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 92.33% 92.31% -0.02%
==========================================
Files 23 23
Lines 1291 1289 -2
Branches 302 302
==========================================
- Hits 1192 1190 -2
Misses 57 57
Partials 42 42
☔ View full report in Codecov by Sentry. |
auvipy
requested changes
Aug 23, 2023
mayeut
reviewed
Sep 10, 2023
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
auvipy
approved these changes
Sep 11, 2023
|
merged as the tests were passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.7 the insertion order to
dicthas been preserved, thus OrderedDict is no longer necessary.Note that
src/auditwheel/_vendor/wheel/wheelfile.pyuses OrderedDict, but is not modified. This was modified upstream from pypa/wheel#561