Manylinux2010 #92
Manylinux2010 #92
Conversation
- Remove libpanel and libncurses from the lib_whitelist (pypa#94) - Generate symbol_versions - Bump priority to 200.
test_manylinux uses an interim manylinux2 image stored on Docker Hub, and a fork of pip that understands the manylinux2 ABI tag.
|
@wtolson, @markrwilliams, thanks for putting this together. At a glance this all looks great to me (love the new symbol generation script), but I do want a chance to review this more closely before I hit merge. I dunno if any of the other maintainers would like to take a look. |
|
Tests are now showing that wheels get |
|
Can this be merged? |
|
@ofek: @njsmith pointed out to me (as does @mayeut's comment above) that manylinux2010 labels are being applied to manylinux1 compliant wheels. The order should be reversed. If a wheel passes both the manylinux1 and manylinux2010 policy, it should be labeled with the more restrictive policy (in that case, manylinux1). So we'll need to get that fixed before this is ready to merge, otherwise this will break backwards compatibility and relabel manylinux1 wheels as manylinux2010, which we don't want. |
auditwheel/policy/policy.json
Outdated
| @@ -25,5 +25,26 @@ | |||
| "libX11.so.6", "libXext.so.6", "libXrender.so.1", "libICE.so.6", | |||
| "libSM.so.6", "libGL.so.1", "libgobject-2.0.so.0", | |||
| "libgthread-2.0.so.0", "libglib-2.0.so.0", "libresolv.so.2" | |||
| ]}, | |||
| {"name": "manylinux2010", | |||
| "priority": 200, | |||
There was a problem hiding this comment.
Following up on my most recent comment, I believe this priority should be lowered such that it is between manylinux1 (most restrictive) and "linux" (least restrictive). Current manylinux1 binaries should also be manylinux2010 compliant, but not vice versa.
There was a problem hiding this comment.
Perhaps we should have done the priorities in increasing rather than decreasing order... feel free to pick an arbitrary number between 0 and 100 for now (90?) and if we need to renumber later because the range was too small we can do that eventually.
|
What needs to be done to get this resolved? Is there some way I can help? |
|
@safijari the policy precedence needs to be adjusted and the tests updated, per my last comment (and others) |
|
I'm committing to getting this merged this upcoming weekend. I'll make the necessary changes. Send me angry emails/GH messages if this isn't merged by Monday the 19th 😄 |
Pick up wheel 0.31.1 pinning, among other changes.
This is an update of @markrwilliams merge request #88. Updates the tag from manylinux2 to manylinux2010 to reflect the changes in PEP 571. Teaches auditwheel about manylinux2010. See pypa/manylinux#152 for the corresponding Docker image.