Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP691 Format support #1154

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Add PEP691 Format support #1154

merged 1 commit into from
Jul 31, 2022

Conversation

cooperlees
Copy link
Contributor

  • Move to 6.0.0.dev0 version
  • Add config for setting formats to save to storage
    • simple-format
    • Valid options: ALL, HTML or JSON
  • Move mirror simple generation functions to new simple module
  • Add new tests to test_simple.py
    • Made tests be included with install by adding an init.py

Tests

  • Add unittest coverage to SimpleAPI object
    • Test valid and invalid format requests
    • Test the JSON output for PEP691 compliance
      • Per pacakge
      • Global index
  • Add check to Integration test to expect json index ...

@cooperlees cooperlees added the enhancement New feature or request label Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1154 (f2c1ddf) into main (c78e7da) will increase coverage by 4.01%.
The diff coverage is 92.43%.

@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
+ Coverage   79.36%   83.38%   +4.01%     
==========================================
  Files          16       31      +15     
  Lines        2641     4218    +1577     
  Branches      493      662     +169     
==========================================
+ Hits         2096     3517    +1421     
- Misses        387      523     +136     
- Partials      158      178      +20     
Impacted Files Coverage Δ
src/bandersnatch/__init__.py 100.00% <ø> (ø)
src/bandersnatch/tests/conftest.py 96.46% <ø> (ø)
src/bandersnatch/tests/test_sync.py 100.00% <ø> (ø)
src/bandersnatch/mirror.py 81.96% <85.00%> (-1.35%) ⬇️
src/bandersnatch/simple.py 89.84% <89.84%> (ø)
src/bandersnatch/configuration.py 86.99% <100.00%> (+0.78%) ⬆️
src/bandersnatch/tests/test_configuration.py 96.51% <100.00%> (ø)
src/bandersnatch/tests/test_filter.py 89.88% <100.00%> (ø)
src/bandersnatch/tests/test_main.py 96.55% <100.00%> (ø)
src/bandersnatch/tests/test_mirror.py 96.65% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78e7da...f2c1ddf. Read the comment docs.

@cooperlees cooperlees force-pushed the pep_691_1 branch 5 times, most recently from 39fde3e to b29167e Compare July 27, 2022 01:38
@ichard26 ichard26 self-requested a review July 27, 2022 02:49
- Move to 6.0.0.dev0 version
- Add config for setting formats to save to storage
  - `simple-format`
  - Valid options: ALL, HTML or JSON
- Move `mirror` simple generation functions to new simple module
- Add new tests to test_simple.py
  - Made tests be included with install by adding an __init__.py

Tests
- Add unittest coverage to SimpleAPI object
  - Test valid and invalid format requests
  - Test the JSON output for PEP691 compliance
    - Per pacakge
    - Global index
- Add check to Integration test to expect json index ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant