Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): Bump s3path from 0.4.2 to 0.5.0 #1525

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2023

Bumps s3path from 0.4.2 to 0.5.0.

Release notes

Sourced from s3path's releases.

New Package Version: 0.5.0

Version 0.5.0

This is a big version.

New Features list:

  • #134 Remove S3DirEntry from the public api
  • #128 Add Type Hints
  • #126 Add PureVersionedS3Path and VersionedS3Path to support S3 keys with versioning
  • #125 Add S3Path.get_presigned_url to create a pre-signed url for the S3 Key
  • Remove Python < 3.8 Version support

Version Bug Fix list:

  • #136 - Python Version 3.11.4 break S3Path.glob
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the skip news Skip CI check for news/changelog label Aug 21, 2023
@dependabot dependabot bot requested a review from cooperlees August 21, 2023 07:39
Bumps [s3path](https://github.com/liormizr/s3path) from 0.4.2 to 0.5.0.
- [Release notes](https://github.com/liormizr/s3path/releases)
- [Commits](liormizr/s3path@0.4.2...0.5.0)

---
updated-dependencies:
- dependency-name: s3path
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/s3path-0.5.0 branch from 9dc7ec7 to b5b2f97 Compare August 21, 2023 16:34
@cooperlees
Copy link
Contributor

cooperlees commented Aug 21, 2023

Damn, looks like we've got API breaking changes here. Will dig into it one day.

Release notes back that up "This is a big version."

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b3cf4a0) 83.54% compared to head (60a3899) 83.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1525   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files          31       31           
  Lines        4308     4308           
  Branches      771      771           
=======================================
  Hits         3599     3599           
  Misses        528      528           
  Partials      181      181           
Files Changed Coverage Δ
src/bandersnatch_storage_plugins/s3.py 80.57% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cooperlees
Copy link
Contributor

Will fix if a better solution is offered. I think using 'private' objects for typing is fine ...

@cooperlees cooperlees merged commit 4de7647 into main Aug 23, 2023
@cooperlees cooperlees deleted the dependabot/pip/s3path-0.5.0 branch August 23, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Skip CI check for news/changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant