Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support min width not detectable #761

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: support min width not detectable #761

merged 1 commit into from
Mar 28, 2024

Conversation

henryiii
Copy link
Contributor

Fix #760.

@henryiii
fix: support min width not detectable
a995b78 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
layday
layday approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@layday layday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

python -m build -h would have failed too before 1.2.0 with sub-zero values, but it’s not something that would’ve been run in CI.

@henryiii henryiii merged commit e5072e3 into pypa:main Mar 28, 2024
57 checks passed
@henryiii henryiii deleted the henryiii/fix/width branch March 28, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layday layday layday approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@gaborbernat gaborbernat Awaiting requested review from gaborbernat gaborbernat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminal size error with 1.2.0
2 participants
@henryiii @layday