Revert "tests: fix under pyproject-hooks 1.2" #829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e0e911c.
abravalheri
reviewed
Oct 15, 2024
| name = "test-no-prepare" | ||
| version = "1.0.0" | ||
| description = "Test extracting metadata from a backend w/out `prepare_metadata_for_build_wheel` hook" | ||
| requires = ['setuptools >= 42.0.0'] |
There was a problem hiding this comment.
Maybe
Suggested change
| requires = ['setuptools >= 42.0.0'] | |
| requires = ['setuptools @ https://github.com/abravalheri/setuptools/archive/refs/heads/issue-pyproject-hooks-206-take2.zip'] |
Or something similar if the idea is to test the specific fix?
(Or maybe it needs to be added to the test dependencies if they are tested without isolation)
There was a problem hiding this comment.
This is indeed tested without isolation.
There was a problem hiding this comment.
First had to verify that this still fails - which it does :)
There was a problem hiding this comment.
Got a error: [Errno 2] No such file or directory: 'test_setuptools-1.0.0/test_setuptools.egg-info' but I think we used to see that occasionally. Most of the jobs passed, though, so it seems to have fixed it!
There was a problem hiding this comment.
Thank you very much @henryiii for testing it!
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #824
Testing fix in pypa/setuptools#4680. See pypa/pyproject-hooks#206.